Skip to content

Allow Staff members to message groups #5922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Apr 11, 2024
Merged

Allow Staff members to message groups #5922

merged 16 commits into from
Apr 11, 2024

Conversation

smithellis
Copy link
Contributor

@smithellis smithellis commented Mar 18, 2024 •
edited
Loading

  • API for messages to get users/groups
  • Added custom form field type in form_fields.py to handle group AND user selection and validation
  • Update form, models, urls and tests for messages
  • Update group profile page to add button for messaging group
  • Removed unnecessary validation from view.py for new_messages
  • Rewrote new_messages to handle Groups
  • New .js file for handling drop down for messages messages.autocomplete.js
  • Updated webpack entrypoints.js to handle new file
  • Updated tokenizer.js
  • Updated outbox.html, read-outbox.html and _inbox.scss
  • Created abstracted group in settings.py for our Staff group
  • Added new cached property to Profile model for in_staff_group
  • Added in_staff_group function to sumo/utils.py ( thanks @escattone ! )

@smithellis smithellis changed the title Allow Staff memebers to message groups Allow Staff members to message groups Mar 18, 2024
@smithellis smithellis force-pushed the v2-allow-pm-to-groups branch from c874653 to 44283fb Compare March 19, 2024 14:28
@smithellis smithellis mentioned this pull request Mar 19, 2024
Closed
@smithellis smithellis force-pushed the v2-allow-pm-to-groups branch 4 times, most recently from 3c747c5 to 361f1cf Compare March 21, 2024 19:56
@smithellis smithellis marked this pull request as ready for review March 21, 2024 19:59
@smithellis smithellis requested a review from akatsoulas March 21, 2024 20:19
@smithellis smithellis force-pushed the v2-allow-pm-to-groups branch from 361f1cf to 8af5103 Compare March 22, 2024 18:22
akatsoulas
akatsoulas requested changes Mar 27, 2024
View reviewed changes
@smithellis smithellis force-pushed the v2-allow-pm-to-groups branch 2 times, most recently from b65a6b7 to d894db5 Compare March 31, 2024 18:34
escattone
escattone requested changes Apr 1, 2024
View reviewed changes
@sharpstar2000 sharpstar2000 mentioned this pull request Apr 4, 2024
Open
smithellis added 13 commits April 9, 2024 11:36
@smithellis
Allow Staff memebers to message groups
de9ad4a 
* api for messages
* Update form, models, urls and tests
* New .js file for users_or_groups handling
* Updated tokenizer.js
* Tweaks to outbox and message reading templates
* icons for user, group selection dropdown
@smithellis
indent
4ce757e
@smithellis
Add request.user to form call, fix placeholder
10db7d7
@smithellis
comment code and update var names
8bf5662
@smithellis
Implement SUMO_STAFF group abstraction
6be0f5f
@smithellis
rename users_or_groups.autocomplete.js
bc37505
@smithellis
rename view
e83ee5a
@smithellis
make tests consistent
8806a73
@smithellis
Drop additional validation from view
8318b11 
* Since validation is handled in `form_fields.py` for the to
  input we don't need to check again in `views.py`
@smithellis
Reduce database hits in view
53c46a0 
Ensure errors appear on form when a To value fails validation
@smithellis
Remove exact match code
af8dadb
@smithellis
Decrease db hits in field validation
da18540
@smithellis
Handle double commas, trailing commas in To
e9646fa
@smithellis smithellis force-pushed the v2-allow-pm-to-groups branch from 9a2cef1 to e9646fa Compare April 9, 2024 15:41
escattone
escattone requested changes Apr 9, 2024
View reviewed changes
escattone
escattone requested changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@escattone escattone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smithellis With this latest realization, I've changed my mind and no longer like the idea of putting is_staff (or whatever we rename it to) on the profile. I'd vote for using the function approach instead.

@smithellis smithellis force-pushed the v2-allow-pm-to-groups branch from 15539a6 to 5d0562f Compare April 10, 2024 21:04
escattone
escattone approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@escattone escattone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc

Just a typo change.

@smithellis smithellis merged commit 7cdffd7 into mozilla:main Apr 11, 2024
@smithellis smithellis deleted the v2-allow-pm-to-groups branch April 11, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akatsoulas akatsoulas akatsoulas requested changes

@escattone escattone escattone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smithellis @akatsoulas @escattone